Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 937783002: [Telemetry] Rename test methods in page_test_results_unittest to follow existing convention of tele… (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
eakuefner, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Rename test methods in page_test_results_unittest to follow existing convention of telemetry Committed: https://crrev.com/6bc3b7b7924ea88572d880e49576089f26e9988d Cr-Commit-Position: refs/heads/master@{#316904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nednguyen
5 years, 10 months ago (2015-02-18 18:41:46 UTC) #2
dtu
lgtm
5 years, 10 months ago (2015-02-18 20:26:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937783002/1
5 years, 10 months ago (2015-02-18 20:32:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/34008)
5 years, 10 months ago (2015-02-18 22:00:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937783002/1
5 years, 10 months ago (2015-02-18 22:07:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 22:50:27 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 22:51:14 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6bc3b7b7924ea88572d880e49576089f26e9988d
Cr-Commit-Position: refs/heads/master@{#316904}

Powered by Google App Engine
This is Rietveld 408576698