Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 937773002: IDL: Support default values for dictionary members of union types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | Source/bindings/scripts/v8_types.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_dictionary.py
diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py
index f6a05787ce9cf6fbd778b0bf197530a2bd0eebc0..3e8ee8cc192ee03ce4136ac0ec47504251279075 100644
--- a/Source/bindings/scripts/v8_dictionary.py
+++ b/Source/bindings/scripts/v8_dictionary.py
@@ -89,7 +89,8 @@ def member_context(dictionary, member):
return None, None
if member.default_value.is_null:
return None, 'v8::Null(isolate)'
- cpp_default_value = str(member.default_value)
+ cpp_default_value = unwrapped_idl_type.literal_cpp_value(
+ member.default_value)
v8_default_value = unwrapped_idl_type.cpp_value_to_v8_value(
cpp_value=cpp_default_value, isolate='isolate',
creation_context='creationContext')
@@ -186,7 +187,7 @@ def member_impl_context(member, interfaces_info, header_includes):
cpp_default_value = None
if member.default_value and not member.default_value.is_null:
- cpp_default_value = str(member.default_value)
+ cpp_default_value = idl_type.literal_cpp_value(member.default_value)
header_includes.update(idl_type.impl_includes_for_type(interfaces_info))
return {
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | Source/bindings/scripts/v8_types.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698