Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 937713004: Push API: Perform exact same-origin test, when checking tab visibility (Closed)

Created:
5 years, 10 months ago by johnme
Modified:
5 years, 10 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@snippet
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Perform exact same-origin test, when checking tab visibility BUG=437277 Committed: https://crrev.com/cd2fa46ade22a4c675adbeccccdb64a896d17ac5 Cr-Commit-Position: refs/heads/master@{#316900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
johnme
5 years, 10 months ago (2015-02-18 18:17:54 UTC) #2
Peter Beverloo
lgtm
5 years, 10 months ago (2015-02-18 18:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937713004/1
5 years, 10 months ago (2015-02-18 21:47:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 21:51:42 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 21:52:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd2fa46ade22a4c675adbeccccdb64a896d17ac5
Cr-Commit-Position: refs/heads/master@{#316900}

Powered by Google App Engine
This is Rietveld 408576698