chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: noms asvitkine comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index 0deb8320b22eef5831cd7ddb237f7b0e10506daf..6b7fd8acf578f3fae6f58878a81905c64786ebe1 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -11,7 +11,7 @@

#include "base/compiler_specific.h"

#include "base/files/file_path.h"

#include "base/metrics/field_trial.h"

-#include "base/metrics/histogram.h"

+#include "base/metrics/histogram_macros.h"

#include "base/prefs/default_pref_store.h"

#include "base/prefs/json_pref_store.h"

#include "base/prefs/pref_filter.h"

@@ -501,6 +501,7 @@ scoped_ptr<PrefServiceSyncable> CreateProfilePrefs(

const scoped_refptr<user_prefs::PrefRegistrySyncable>& pref_registry,

bool async) {

TRACE_EVENT0("browser", "chrome_prefs::CreateProfilePrefs");

+ SCOPED_UMA_HISTOGRAM_TIMER("PrefService.CreateProfilePrefsTime");

// A StartSyncFlare used to kick sync early in case of a reset event. This is

// done since sync may bring back the user's server value post-reset which

« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')