Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/browser/profiles/profile_manager.h

Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: noms comment p2 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager.h
diff --git a/chrome/browser/profiles/profile_manager.h b/chrome/browser/profiles/profile_manager.h
index c16b6df8736a59c25eccfc0b8a68ef5fd76339b6..83cf34e43902cc45420c5ec4df4755a0057506bd 100644
--- a/chrome/browser/profiles/profile_manager.h
+++ b/chrome/browser/profiles/profile_manager.h
@@ -76,6 +76,7 @@ class ProfileManager : public base::NonThreadSafe,
// otherwise it will create and manage it.
Profile* GetProfile(const base::FilePath& profile_dir);
+
noms (inactive) 2015/02/18 21:32:19 nit: extra \n
rkaplow 2015/02/19 00:18:57 Done.
// Returns total number of profiles available on this machine.
size_t GetNumberOfProfiles();
@@ -256,6 +257,10 @@ class ProfileManager : public base::NonThreadSafe,
// Returns true if the profile was added, false otherwise.
bool AddProfile(Profile* profile);
+ // Creates and returns a profile. This handles both the full creation and
+ // handles the management.
noms (inactive) 2015/02/18 21:32:19 nit: I would change this to "Synchronously creates
rkaplow 2015/02/19 00:18:57 Done.
+ Profile* CreateAndInitializeProfile(const base::FilePath& profile_dir);
+
// Schedules the profile at the given path to be deleted on shutdown.
void FinishDeletingProfile(const base::FilePath& profile_dir);

Powered by Google App Engine
This is Rietveld 408576698