chrome/browser/prefs/browser_prefs.cc - Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 937713003: Add several new TRACE call and UMA metrics for GetProfile() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: noms comment p2 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/browser_prefs.cc

diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc

index 635f01e771e62bfff8847d5cf1de23a42e8865ab..88209877b10658772773b51080be1881dd9f9620 100644

--- a/chrome/browser/prefs/browser_prefs.cc

+++ b/chrome/browser/prefs/browser_prefs.cc

@@ -6,7 +6,7 @@

#include <string>

-#include "base/metrics/histogram.h"

+#include "base/metrics/histogram_macros.h"

#include "base/prefs/pref_registry_simple.h"

#include "base/prefs/pref_service.h"

#include "base/prefs/scoped_user_pref_update.h"

@@ -379,7 +379,8 @@ void RegisterLocalState(PrefRegistrySimple* registry) {

// Register prefs applicable to all profiles.

void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {

- TRACE_EVENT0("browser", "chrome::RegisterUserPrefs");

+ TRACE_EVENT0("browser", "chrome::RegisterProfilePrefs");

+ SCOPED_UMA_HISTOGRAM_TIMER("Settings.RegisterProfilePrefsTime");

// User prefs. Please keep this list alphabetized.

autofill::AutofillManager::RegisterProfilePrefs(registry);

bookmarks::RegisterProfilePrefs(registry);

« no previous file with comments | « no previous file | chrome/browser/prefs/chrome_pref_service_factory.cc » ('j') | chrome/browser/profiles/profile_impl.cc » ('J')