Issue 937683002: Don't use 'current' if 'from' is not relative.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 937683002: Don't use 'current' if 'from' is not relative. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/path@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't use 'current' if 'from' is not relative. R=rnystrom@google.com BUG= Committed: https://github.com/dart-lang/path/commit/93b3e2aa1db0ac0c8bab9d341588d77acda60320

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -3 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/context.dart	View	1 chunk	+5 lines, -1 line	1 comment	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/relative_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! Don't forget to publish it! https://codereview.chromium.org/937683002/diff/1/lib/src/context.dart File lib/src/context.dart (right): https://codereview.chromium.org/937683002/diff/1/lib/src/context.dart#newcode329 lib/src/context.dart:329: } else if ...

5 years, 10 months ago (2015-02-18 17:09:09 UTC) #2

scheglov

5 years, 10 months ago (2015-02-18 17:41:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93b3e2aa1db0ac0c8bab9d341588d77acda60320 (presubmit successful).

Expand Messages | Collapse Messages