New batch of dlls to evict from the render process (top crashers).

New batch of dlls to evict from the render process (top crashers).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4797

[Peter Kasting, 2008-11-05 00:18:14]

http://codereview.chromium.org/9376/diff/1/2
File chrome/browser/sandbox_policy.cc (right):

http://codereview.chromium.org/9376/diff/1/2#newcode99
Line 99: // when they are loaded in the render process.
Nit: renderer?

http://codereview.chromium.org/9376/diff/1/2#newcode102
Line 102: const wchar_t* troublesome_dlls[] = {
Nit: Any chance of vertically the comments here for readability?

http://codereview.chromium.org/9376/diff/1/2#newcode104
Line 104: L"acpiz.dll",
Nit: What program is this?

http://codereview.chromium.org/9376/diff/1/2#newcode136
Line 136: L"sbrige.dll",
Nit: What program is this?

http://codereview.chromium.org/9376/diff/1/2#newcode140
Line 140: L"ssldivx.dll",  // OpenSSL.
Nit: Isn't this another DivX DLL?

[rvargas (doing something else), 2008-11-05 01:28:07]

Thanks, new version uploaded.

On 2008/11/05 00:18:14, pkasting wrote:
> http://codereview.chromium.org/9376/diff/1/2
> File chrome/browser/sandbox_policy.cc (right):
> 
> http://codereview.chromium.org/9376/diff/1/2#newcode99
> Line 99: // when they are loaded in the render process.
> Nit: renderer?
> 
> http://codereview.chromium.org/9376/diff/1/2#newcode102
> Line 102: const wchar_t* troublesome_dlls[] = {
> Nit: Any chance of vertically the comments here for readability?
> 
> http://codereview.chromium.org/9376/diff/1/2#newcode104
> Line 104: L"acpiz.dll",
> Nit: What program is this?
> 
> http://codereview.chromium.org/9376/diff/1/2#newcode136
> Line 136: L"sbrige.dll",
> Nit: What program is this?

These two dlls are not part of a regular application. For all we know they are
malware (acpiz.dll is actually identified as such, but it has at least three
different names). If you feel strongly about it I can say "malware", but I
thought it was better not to name names (there is actually a product named
sbridge).

> 
> http://codereview.chromium.org/9376/diff/1/2#newcode140
> Line 140: L"ssldivx.dll",  // OpenSSL.
> Nit: Isn't this another DivX DLL?

Yes, I was going with the most frequent description, but DivX is probably more
accurate.

[M-A Ruel, 2008-11-05 01:31:41]

lgtm with 2 nits

http://codereview.chromium.org/9376/diff/204/205
File chrome/browser/sandbox_policy.cc (right):

http://codereview.chromium.org/9376/diff/204/205#newcode23
Line 23: const wchar_t* kTroublesomeDlls[] = {
const wchar_t* const kTroublesomeDlls[] = {

http://codereview.chromium.org/9376/diff/204/205#newcode70
Line 70: }
}  // namespace

[cpu_(ooo_6.6-7.5), 2008-11-05 02:12:47]

LGTM

[Peter Kasting, 2008-11-05 05:14:33]

LGTM.  I would probably go ahead and say "Malware (?)" or similar on those blank
lines but it isn't a big deal.