Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: remoting/webapp/base/js/base.js

Issue 937593002: Changed identity API to use promises instead of callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed bad merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/base/js/auth_init.js ('k') | remoting/webapp/crd/js/apps_v2_migration.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/base/js/base.js
diff --git a/remoting/webapp/base/js/base.js b/remoting/webapp/base/js/base.js
index d3599a56911d814fe2a3bff8dc09a4a9e3266b84..bbf29107929d9b84ee44317782f146d5f664d76b 100644
--- a/remoting/webapp/base/js/base.js
+++ b/remoting/webapp/base/js/base.js
@@ -237,17 +237,16 @@ base.escapeHTML = function(str) {
* };
*
* @constructor
+ * @template T
*/
base.Deferred = function() {
/**
- * @type {?function(?):void}
- * @private
+ * @private {?function(?):void}
*/
this.resolve_ = null;
/**
- * @type {?function(?):void}
- * @private
+ * @private {?function(?):void}
*/
this.reject_ = null;
@@ -262,8 +261,7 @@ base.Deferred = function() {
};
/**
- * @type {Promise}
- * @private
+ * @private {!Promise<T>}
*/
this.promise_ = new Promise(initPromise.bind(this));
};
@@ -278,7 +276,7 @@ base.Deferred.prototype.resolve = function(opt_value) {
this.resolve_(opt_value);
};
-/** @return {Promise} */
+/** @return {!Promise<T>} */
base.Deferred.prototype.promise = function() {
return this.promise_;
};
« no previous file with comments | « remoting/webapp/base/js/auth_init.js ('k') | remoting/webapp/crd/js/apps_v2_migration.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698