remoting/webapp/base/js/auth_dialog.js - Issue 937593002: Changed identity API to use promises instead of callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/base/js/auth_dialog.js

Issue 937593002: Changed identity API to use promises instead of callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed bad merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/base/js/auth_dialog.js

diff --git a/remoting/webapp/base/js/auth_dialog.js b/remoting/webapp/base/js/auth_dialog.js

index bdb2b488f498f045c2bd8398f8dac29085c12662..34b621c885d23b6f510466b67bff12d927590b73 100644

--- a/remoting/webapp/base/js/auth_dialog.js

+++ b/remoting/webapp/base/js/auth_dialog.js

@@ -63,7 +63,7 @@ remoting.AuthDialog.prototype.addToRegion = function(rects) {

/** @private */

remoting.AuthDialog.prototype.onClick_ = function() {

this.rootElement_.hidden = true;

- this.onAuthButtonDeferred_.resolve();

+ this.onAuthButtonDeferred_.resolve(null);

this.onAuthButtonDeferred_ = null;

remoting.windowShape.updateClientWindowShape();

};

« no previous file with comments | « no previous file | remoting/webapp/base/js/auth_init.js » ('j') | no next file with comments »