Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: components/cronet/android/cronet_pref_store.h

Issue 937513003: Add Data Saver support to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_pref_store.h
diff --git a/android_webview/browser/aw_pref_store.h b/components/cronet/android/cronet_pref_store.h
similarity index 70%
copy from android_webview/browser/aw_pref_store.h
copy to components/cronet/android/cronet_pref_store.h
index 6935c7190a864dd91a18c0d5d99fb386915a552f..f229b79e6ccd64cce9423c019640bc6155168828 100644
--- a/android_webview/browser/aw_pref_store.h
+++ b/components/cronet/android/cronet_pref_store.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
-#define ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
+#ifndef COMPONENTS_CRONET_ANDROID_CRONET_PREF_STORE_H_
+#define COMPONENTS_CRONET_ANDROID_CRONET_PREF_STORE_H_
#include <string>
@@ -17,11 +17,11 @@
// in a memory backed store. This is not a persistent prefstore -- we
// subclass the PersistentPrefStore here since it is needed by the
// PrefService, which in turn is needed by the Autofill component.
-class AwPrefStore : public PersistentPrefStore {
+class CronetPrefStore : public PersistentPrefStore {
mmenke 2015/03/13 18:16:48 Given that this class is identical to the AwPrefSt
bengr 2015/03/19 01:03:51 Good suggestion. Let's do this as a followup.
public:
- AwPrefStore();
+ CronetPrefStore();
- // Overriden from PrefStore.
+ // Overrides from PrefStore:
bool GetValue(const std::string& key,
const base::Value** result) const override;
void AddObserver(PrefStore::Observer* observer) override;
@@ -30,10 +30,12 @@ class AwPrefStore : public PersistentPrefStore {
bool IsInitializationComplete() const override;
// PersistentPrefStore overrides:
- bool GetMutableValue(const std::string& key, base::Value** result) override;
+ bool GetMutableValue(const std::string& key,
+ base::Value** result) override;
void ReportValueChanged(const std::string& key) override;
void SetValue(const std::string& key, base::Value* value) override;
- void SetValueSilently(const std::string& key, base::Value* value) override;
+ void SetValueSilently(const std::string& key,
+ base::Value* value) override;
void RemoveValue(const std::string& key) override;
bool ReadOnly() const override;
PrefReadError GetReadError() const override;
@@ -42,7 +44,7 @@ class AwPrefStore : public PersistentPrefStore {
void CommitPendingWrite() override {}
protected:
- ~AwPrefStore() override;
+ ~CronetPrefStore() override;
private:
// Stores the preference values.
@@ -50,7 +52,7 @@ class AwPrefStore : public PersistentPrefStore {
ObserverList<PrefStore::Observer, true> observers_;
- DISALLOW_COPY_AND_ASSIGN(AwPrefStore);
+ DISALLOW_COPY_AND_ASSIGN(CronetPrefStore);
};
-#endif // ANDROID_WEBVIEW_BROWSER_AW_PREF_STORE_H_
+#endif // COMPONENTS_CRONET_ANDROID_CRONET_PREF_STORE_H_

Powered by Google App Engine
This is Rietveld 408576698