Add Data Saver support to Cronet

components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.content.Context;
 import android.content.ContextWrapper;
 import android.os.ConditionVariable;
 import android.os.Handler;
@@ skipping 85 matching lines @@
         UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
                 NativeTestServer.getEchoHeaderURL(userAgentName), listener,
                 listener.getExecutor());
         urlRequest.start();
         listener.blockForDone();
         assertEquals(userAgentValue, listener.mResponseAsString);
     }
 
     @SmallTest
     @Feature({"Cronet"})
+    public void testDataReductionProxyEnabled() throws Exception {
+        UrlRequestContextConfig config = new UrlRequestContextConfig();
+        config.setLibraryName("cronet_tests");
+        String[] commandLineArgs = {
+                CronetTestActivity.CONFIG_KEY, config.toString()
+        };
+        mActivity = launchCronetTestAppWithUrlAndCommandLineArgs(null,
+                commandLineArgs);

[mmenke, 2015/05/07 20:22:18]

Can you just do something like:

// Ensure native code is loaded before trying to start test server.
UrlRequestContext.createContext(this, config).shutdown();

Even if that doesn't work for some reason, think it's worth a comment what's
going on.

[bengr, 2015/05/08 22:41:02]

Done.

+        assertTrue(NativeTestServer.startNativeTestServer(
+                getInstrumentation().getTargetContext()));
+
+        String serverHostPort = NativeTestServer.getHostPort();
+        // Shutdown the original context and create a new context that uses the
+        // NativeTestServer as the data reduction proxy.
+        mActivity.mUrlRequestContext.shutdown();
+        UrlRequestContextConfig config2 = new UrlRequestContextConfig();
+        config2.enableDataReductionProxy("test-key");
+        config2.setDataReductionProxyOptions(
+                serverHostPort, "unused.net:9999",
+                NativeTestServer.getFileURL("/secureproxychecksuccess.txt"));
+        config2.setLibraryName("cronet_tests");
+        mActivity.mUrlRequestContext =
+                mActivity.mUrlRequestContext.createContext(
+                        getInstrumentation().getTargetContext(), config2);
+        TestUrlRequestListener listener = new TestUrlRequestListener();
+        UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+                "http://google.com/datareductionproxysuccess.txt",
+                listener, listener.getExecutor());
+
+        urlRequest.start();
+        listener.blockForDone();
+        assertEquals(200, listener.mResponseInfo.getHttpStatusCode());
+        assertEquals(serverHostPort, listener.mResponseInfo.getProxyServer());
+        assertEquals("http://www.google.com/datareductionproxysuccess.txt",
+                listener.mResponseInfo.getUrl());

[mmenke, 2015/05/07 20:22:18]

Also think it's worth an explanation of just what this test is really doing.

[bengr, 2015/05/08 22:41:02]

Done.

+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
     public void testShutdown() throws Exception {
         mActivity = launchCronetTestApp();
         TestUrlRequestListener listener = new ShutdownTestUrlRequestListener();
         // Block listener when response starts to verify that shutdown fails
         // if there are active requests.
         listener.setAutoAdvance(false);
         UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
                 TEST_URL, listener, listener.getExecutor());
         urlRequest.start();
         try {
@@ skipping 471 matching lines @@
                 new CronetUrlRequestContext(mActivity, mActivity.getContextConfig());
         CronetUrlRequestContext secondContext = new CronetUrlRequestContext(
                 mActivity.getApplicationContext(), mActivity.getContextConfig());
         CronetUrlRequestContext thirdContext = new CronetUrlRequestContext(
                 new ContextWrapper(mActivity), mActivity.getContextConfig());
         firstContext.shutdown();
         secondContext.shutdown();
         thirdContext.shutdown();
     }
 }