Add Data Saver support to Cronet

components/cronet/android/java/src/org/chromium/net/UrlRequestContextConfig.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
 
@@ skipping 84 matching lines @@
     }
 
     /**
      * Boolean, enable SPDY if true.
      */
     public UrlRequestContextConfig enableSPDY(boolean value) {
         return putBoolean(UrlRequestContextConfigList.ENABLE_SPDY, value);
     }
 
     /**
+     * Boolean, enable Data Reduction Proxy if true. The key is used to
+     * authenticate with the proxy.
+     */
+    public UrlRequestContextConfig enableDataReductionProxy(boolean value,

[mmenke, 2015/04/24 19:10:28]

Wonder if we really need a value - if you don't want it, don't enable it (The
ones above are a bit different, as default may change over time).

[bengr, 2015/04/24 21:13:51]

Probably not necessary immediately, but I wanted eventually to add support to
turn it off/on over time.

[mmenke, 2015/04/24 21:17:59]

Note that we don't support modifying the config after creation, and really can't
support it, so we'd need to use another method to enable/disable it on a live
RequestContext than just creating a new config

[bengr, 2015/04/24 22:12:44]

Done.

+            String key) {
+        return (putBoolean(UrlRequestContextConfigList
+                        .ENABLE_DATA_REDUCTION_PROXY, value)
+                    .putString(UrlRequestContextConfigList
+                            .DATA_REDUCTION_PROXY_KEY, key));
+    }
+
+    /**
      * Enumeration, disable or enable cache in memory or on disk.
      */
     public enum HttpCache {
         /**
          * Disable cache, some data may still be temporarily stored in memory.
          */
         DISABLED,
 
         /**
          * Enable in memory cache, including HTTP data.
@@ skipping 95 matching lines @@
      * @param quicConnectionOptions comma-separated QUIC options (for example
      * "PACE,IW10") to use if QUIC is enabled.
      */
     public UrlRequestContextConfig setExperimentalQuicConnectionOptions(
             String quicConnectionOptions) {
         return putString(UrlRequestContextConfigList.QUIC_OPTIONS,
                          quicConnectionOptions);
     }
 
     /**
+     * Overrides Data Reduction Proxy configuration parameters with a primary

[mmenke, 2015/04/24 19:10:28]

Overrides parameters implies we have defaults, but we don't, do we?

[bengr, 2015/04/24 21:13:51]

We do. They are hard coded in DRP code for now.

+     * proxy name, fallback proxy name, and a secure proxy check url. Proxies
+     * are specified as scheme://host[:port].
+     * @param primaryProxy
+     * @param fallbackProxy
+     * @param secureProxyCheck
+     */

[mmenke, 2015/04/24 19:10:28]

Suggest moving this below the other DRP method (Know the quic methods aren't
next to each other, but seems like the file is easier to read if related methods
are adjacent.

[bengr, 2015/04/24 21:13:51]

Done.

+    public UrlRequestContextConfig setDataReductionProxyOptions(
+            String primaryProxy,
+            String fallbackProxy,
+            String secureProxyCheckUrl) {

[mmenke, 2015/04/24 19:10:28]

IF any of these are empty throw an IllegalArgumentException?  It's preferred
over just DCHECKing in the C++ code.

[bengr, 2015/04/24 21:13:51]

Done.

+        return putString(
+                UrlRequestContextConfigList.DATA_REDUCTION_PRIMARY_PROXY,
+                primaryProxy)
+                .putString(UrlRequestContextConfigList
+                        .DATA_REDUCTION_FALLBACK_PROXY, fallbackProxy)
+                        .putString(UrlRequestContextConfigList
+                                .DATA_REDUCTION_SECURE_PROXY_CHECK_URL,
+                                secureProxyCheckUrl);

[mmenke, 2015/04/24 19:10:28]

Think this would be more legibly as just 3 independent putString calls, any a
return.

[bengr, 2015/04/24 21:13:51]

Done.

+    }
+
+    /**
      * Get JSON string representation of the config.
      */
     @Override
     public String toString() {
         return mConfig.toString();
     }
 
     /**
      * Sets a boolean value in the config. Returns a reference to the same
      * config object, so you can chain put calls together.
@@ skipping 28 matching lines @@
         try {
             mConfig.put(key, value);
         } catch (JSONException e) {
             // Intentionally do nothing.
         }
         return this;
     }
 
     private JSONObject mConfig = new JSONObject();
 }