Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: components/cronet/android/cronet_in_memory_pref_store.cc

Issue 937513003: Add Data Saver support to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/cronet/android/cronet_in_memory_pref_store.h"
6
7 #include "base/memory/scoped_ptr.h"
8 #include "base/values.h"
mmenke 2015/04/24 19:27:23 I don't think this is needed - we just base Value*
bengr 2015/04/24 21:13:50 Done.
9
10 CronetInMemoryPrefStore::CronetInMemoryPrefStore() {}
11
12 CronetInMemoryPrefStore::~CronetInMemoryPrefStore() {}
13
14 bool CronetInMemoryPrefStore::GetValue(const std::string& key,
15 const base::Value** value) const {
16 return prefs_.GetValue(key, value);
17 }
18
19 bool CronetInMemoryPrefStore::GetMutableValue(const std::string& key,
20 base::Value** value) {
21 return prefs_.GetValue(key, value);
22 }
23
24 void CronetInMemoryPrefStore::AddObserver(PrefStore::Observer* observer) {
25 observers_.AddObserver(observer);
26 }
27
28 void CronetInMemoryPrefStore::RemoveObserver(PrefStore::Observer* observer) {
29 observers_.RemoveObserver(observer);
30 }
31
32 bool CronetInMemoryPrefStore::HasObservers() const {
33 return observers_.might_have_observers();
34 }
35
36 bool CronetInMemoryPrefStore::IsInitializationComplete() const {
37 return true;
38 }
39
40 void CronetInMemoryPrefStore::SetValue(
41 const std::string& key, base::Value* value) {
42 DCHECK(value);
43 if (prefs_.SetValue(key, value))
44 ReportValueChanged(key);
45 }
46
47 void CronetInMemoryPrefStore::SetValueSilently(const std::string& key,
48 base::Value* value) {
49 prefs_.SetValue(key, value);
50 }
51
52 void CronetInMemoryPrefStore::RemoveValue(const std::string& key) {
53 if (prefs_.RemoveValue(key))
54 ReportValueChanged(key);
55 }
56
57 bool CronetInMemoryPrefStore::ReadOnly() const {
58 return false;
59 }
60
61 PersistentPrefStore::PrefReadError
62 CronetInMemoryPrefStore::GetReadError() const {
63 return PersistentPrefStore::PREF_READ_ERROR_NONE;
64 }
65
66 PersistentPrefStore::PrefReadError CronetInMemoryPrefStore::ReadPrefs() {
67 return PersistentPrefStore::PREF_READ_ERROR_NONE;
68 }
69
70 void CronetInMemoryPrefStore::ReadPrefsAsync(
71 ReadErrorDelegate* error_delegate_raw) {
72 }
73
74 void CronetInMemoryPrefStore::ReportValueChanged(const std::string& key) {
75 FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
76 }
77
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698