Change the type of icudata target to none

Change the type of icudata target to none

When icu_use_data_file_flag==1, nothing is done other than copying
icudtl.dat. [1]  Therefore, the type is changed to 'none' from
'static_library'.

Although I couldn't locally reproduce the problme, one of iOS try bots
tried to link with libicudata.a [2] and failed when the type is 'static_library'.
This change should fix the problem.


[1] http://codereview.chromium.org/926113004 moved stubdata.c to icuuc.
[2] https://codereview.chromium.org/878723002/ PS 14 has the above change in
icu.gyp. ios_dbg_simulator_ng failed to link looking for libicudata.a in the
1st try. When I ran the trybot again, the compile went through.

BUG=428145
TEST=All bots (including iOS bots) can build successfully.
R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/dfcce371da4b0031f5dd5f7588a050258e1076cb

[jungshik at Google, 2015-02-17 21:25:18]

jshin@chromium.org changed reviewers:
+ mark@chromium.org, stuartmorgan@chromium.org

[jungshik at Google, 2015-02-17 21:25:18]

Can you take a look? Thanks

[Mark Mentovai, 2015-02-17 21:27:25]

LGTM

[jungshik at Google, 2015-02-17 21:27:38]

https://codereview.chromium.org/937513002/diff/1/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/937513002/diff/1/icu.gyp#newcode148
icu.gyp:148: 'link_settings': {
I was worried that link_settings may not do anything when type is set to 'none',
but both iphonesimulator and iphoneos builds copied icudtl.dat with type set to
'none'.

[jungshik at Google, 2015-02-17 22:41:33]

Committed patchset #1 (id:1) manually as
dfcce371da4b0031f5dd5f7588a050258e1076cb (presubmit successful).

[stuartmorgan, 2015-02-18 16:14:03]

LGTM. I believe the reason you couldn't repro is that Xcode and ninja react
differently to static_library targets without sources.

[jungshik at Google, 2015-02-18 18:09:08]

On 2015/02/18 16:14:03, stuartmorgan wrote:
> LGTM. I believe the reason you couldn't repro is that Xcode and ninja react
> differently to static_library targets without sources.

Thank you. I didn't realize that ios build bots (some of them) use Xcode. 

BTW, ios_dbg_simulator_ng bot is still "failing" even with this change. It's
strange that all the tests with patch passed. After that, those tests were
re-run apparently without patch and "failed" saying " TEST RESULTS WERE INVALID"

This behavior was repeated 3 times so that it's not 'ephemeral'. 

http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...

Perhaps, I need to talk to the infra-team about this. Before that, I wonder if
you have any hunch as to why.   

Jungshik

[stuartmorgan, 2015-02-18 18:23:14]

On 2015/02/18 18:09:08, Jungshik at google wrote:
> BTW, ios_dbg_simulator_ng bot is still "failing" even with this change. It's
> strange that all the tests with patch passed. After that, those tests were
> re-run apparently without patch and "failed" saying " TEST RESULTS WERE
INVALID"

I'm not sure what that indicates exactly; infra would indeed be the best next
step.