Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 937473003: win vs2015: avoid variable shadowing warning in url_canon.h (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win vs2015: avoid variable shadowing warning in url_canon.h d:\src\cr2\src\url\url_canon.h(737): error C2220: warning treated as error - no 'object' file generated d:\src\cr2\src\url\url_canon.h(737): warning C4459: declaration of 'empty_string' hides global declaration d:\src\cr2\src\url\gurl.cc(22): note: see declaration of '`anonymous-namespace'::empty_string' R=brettw@chromium.org BUG=440500 Committed: https://crrev.com/df75e1de1238c157580ec10d6f9478d7222b4d69 Cr-Commit-Position: refs/heads/master@{#317431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M url/url_canon.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 10 months ago (2015-02-20 05:06:48 UTC) #1
brettw
lgtm
5 years, 10 months ago (2015-02-20 21:02:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937473003/1
5 years, 10 months ago (2015-02-20 21:41:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 22:42:44 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:43:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df75e1de1238c157580ec10d6f9478d7222b4d69
Cr-Commit-Position: refs/heads/master@{#317431}

Powered by Google App Engine
This is Rietveld 408576698