Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 937423002: Revert of Dispatch directory-changed event before rescan starts. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dispatch directory-changed event before rescan starts. (patchset #1 id:1 of https://codereview.chromium.org/943473002/) Reason for revert: This CL broke as described in http://crbug.com/460398. This issue is going to be fixed in different way with another CL. Original issue's description: > Dispatch directory-changed event before rescan starts. > > Directory rescan sometimes uses up IO and blocks other IOs which are necessary > for updating the top-left breadcrumb. While this CL does not solve the real > cause of the issue, this CL mitigates the problem by dispatching event earlier. > > BUG=459864 > TEST=manually tested as described in the issue > > Committed: https://crrev.com/3027da7aee006ad04e084690d6ea410a31969728 > Cr-Commit-Position: refs/heads/master@{#317021} TBR=fukino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459864 Committed: https://crrev.com/afe477952010b25941baf77604ab2416b3b7dc28 Cr-Commit-Position: refs/heads/master@{#317264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 2 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yawano
Created Revert of Dispatch directory-changed event before rescan starts.
5 years, 10 months ago (2015-02-20 07:27:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937423002/1
5 years, 10 months ago (2015-02-20 07:28:40 UTC) #2
fukino
On 2015/02/20 07:27:35, yawano wrote: > Created Revert of Dispatch directory-changed event before rescan starts. ...
5 years, 10 months ago (2015-02-20 07:28:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 07:29:12 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 07:29:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afe477952010b25941baf77604ab2416b3b7dc28
Cr-Commit-Position: refs/heads/master@{#317264}

Powered by Google App Engine
This is Rietveld 408576698