win vs2015: fix shadowing warnings in net/url_request

win vs2015: fix shadowing warnings in net/url_request

d:\src\cr2\src\net\url_request\url_request_filter.cc(149): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_filter.cc(149): warning C4456: declaration of 'it' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_filter.cc(141): note: see declaration of 'it'

d:\src\cr2\src\net\url_request\url_request_http_job.cc(917): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_http_job.cc(917): warning C4456: declaration of 'context' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_http_job.cc(859): note: see declaration of 'context'

d:\src\cr2\src\net\url_request\url_request_job_manager.cc(79): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\url_request\url_request_job_manager.cc(79): warning C4456: declaration of 'job' hides previous local declaration
d:\src\cr2\src\net\url_request\url_request_job_manager.cc(71): note: see declaration of 'job'

ninja: build stopped: subcommand failed.
R=eroman@chromium.org
BUG=440500
Committed: https://crrev.com/66af5887986c6e397eb502be312a98dc6e7d6d9b
Cr-Commit-Position: refs/heads/master@{#317384}

[scottmg, 2015-02-20 05:14:10]

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_http_job.cc (left):

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
net/url_request/url_request_http_job.cc:917: const URLRequestContext* context =
request_->context();
i'm assuming here that request_ won't return a different context() than at line
859.

[eroman, 2015-02-20 07:36:45]

lgtm

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_filter.cc (right):

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
net/url_request/url_request_filter.cc:149: URLInterceptorMap::const_iterator
url_it = url_interceptor_map_.find(url);
or alternately put curlies around the preceding |it| to reduce its scope.

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_http_job.cc (left):

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
net/url_request/url_request_http_job.cc:917: const URLRequestContext* context =
request_->context();
On 2015/02/20 05:14:10, scottmg wrote:
> i'm assuming here that request_ won't return a different context() than at
line
> 859.

Yes that is a safe assumption.

[scottmg, 2015-02-20 19:19:18]

New patchsets have been uploaded after l-g-t-m from eroman@chromium.org

[scottmg, 2015-02-20 19:19:41]

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
File net/url_request/url_request_filter.cc (right):

https://codereview.chromium.org/937393002/diff/1/net/url_request/url_request_...
net/url_request/url_request_filter.cc:149: URLInterceptorMap::const_iterator
url_it = url_interceptor_map_.find(url);
On 2015/02/20 07:36:45, eroman wrote:
> or alternately put curlies around the preceding |it| to reduce its scope.

Sure, done.

[scottmg, 2015-02-20 19:19:44]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:20:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937393002/20001

[commit-bot: I haz the power, 2015-02-20 20:16:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 20:17:03]

Patchset 2 (id:??) landed as
https://crrev.com/66af5887986c6e397eb502be312a98dc6e7d6d9b
Cr-Commit-Position: refs/heads/master@{#317384}