Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: sandbox/win/src/app_container_test.cc

Issue 937353002: Adding method to create process using LowBox token in sandbox code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed sid.h/.cc Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/win/src/app_container_test.cc
diff --git a/sandbox/win/src/app_container_test.cc b/sandbox/win/src/app_container_test.cc
index 1bfab2c3145b3c91a69634049d9c652c480770c8..b155ea35c3ef31398b1857e7f57fd901aee65b3f 100644
--- a/sandbox/win/src/app_container_test.cc
+++ b/sandbox/win/src/app_container_test.cc
@@ -68,7 +68,7 @@ HANDLE CreateTaggedEvent(const base::string16& name,
namespace sandbox {
-TEST(AppContainerTest, AllowOpenEvent) {
+TEST(AppContainerTest, DenyOpenEvent) {
if (base::win::OSInfo::GetInstance()->version() < base::win::VERSION_WIN8)
return;
@@ -81,18 +81,17 @@ TEST(AppContainerTest, AllowOpenEvent) {
EXPECT_EQ(SBOX_ALL_OK,
runner.broker()->InstallAppContainer(kAppContainerSid,
kAppContainerName));
- EXPECT_EQ(SBOX_ALL_OK, runner.GetPolicy()->SetCapability(capability));
EXPECT_EQ(SBOX_ALL_OK, runner.GetPolicy()->SetAppContainer(kAppContainerSid));
- EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"Event_Open f test"));
+ EXPECT_EQ(SBOX_TEST_DENIED, runner.RunTest(L"Event_Open f test"));
runner.SetTestState(BEFORE_REVERT);
- EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"Event_Open f test"));
+ EXPECT_EQ(SBOX_TEST_DENIED, runner.RunTest(L"Event_Open f test"));
EXPECT_EQ(SBOX_ALL_OK,
runner.broker()->UninstallAppContainer(kAppContainerSid));
}
-TEST(AppContainerTest, DenyOpenEvent) {
+TEST(AppContainerTest, DenyOpenEventEvenWithCapability) {
if (base::win::OSInfo::GetInstance()->version() < base::win::VERSION_WIN8)
return;
@@ -105,6 +104,7 @@ TEST(AppContainerTest, DenyOpenEvent) {
EXPECT_EQ(SBOX_ALL_OK,
runner.broker()->InstallAppContainer(kAppContainerSid,
kAppContainerName));
+ EXPECT_EQ(SBOX_ALL_OK, runner.GetPolicy()->SetCapability(capability));
rvargas (doing something else) 2015/02/27 20:16:34 ... And tests that deal with LowBox don't require
EXPECT_EQ(SBOX_ALL_OK, runner.GetPolicy()->SetAppContainer(kAppContainerSid));
EXPECT_EQ(SBOX_TEST_DENIED, runner.RunTest(L"Event_Open f test"));
@@ -128,7 +128,7 @@ TEST(AppContainerTest, WantsImpersonation) {
return;
TestRunner runner(JOB_UNPROTECTED, USER_UNPROTECTED, USER_NON_ADMIN);
- EXPECT_EQ(SBOX_ERROR_CANNOT_INIT_APPCONTAINER,
+ EXPECT_EQ(SBOX_ALL_OK,
runner.GetPolicy()->SetAppContainer(kAppContainerSid));
}
@@ -137,7 +137,7 @@ TEST(AppContainerTest, RequiresImpersonation) {
return;
TestRunner runner(JOB_UNPROTECTED, USER_RESTRICTED, USER_RESTRICTED);
- EXPECT_EQ(SBOX_ERROR_CANNOT_INIT_APPCONTAINER,
+ EXPECT_EQ(SBOX_ALL_OK,
runner.GetPolicy()->SetAppContainer(kAppContainerSid));
}

Powered by Google App Engine
This is Rietveld 408576698