content/common/input/touch_action.h - Issue 93733005: Implement support for touch-action: pan-x/pan-y in chromium

Side by Side Diff: content/common/input/touch_action.h

Issue 93733005: Implement support for touch-action: pan-x/pan-y in chromium (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Apply jdduke CR feedback Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/input/touch_action_filter.cc ('K') | « content/common/input/synthetic_web_input_event_builders.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_COMMON_INPUT_TOUCH_ACTION_H_	5 #ifndef CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

6 #define CONTENT_COMMON_INPUT_TOUCH_ACTION_H_	6 #define CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

7	7

8 namespace content {	8 namespace content {

9	9

10 // The current touch action specifies what accelerated browser operations	10 // The current touch action specifies what accelerated browser operations

11 // (panning and zooming) are currently permitted via touch input.	11 // (panning and zooming) are currently permitted via touch input.

12 // See http://www.w3.org/TR/pointerevents/#the-touch-action-css-property.	12 // See http://www.w3.org/TR/pointerevents/#the-touch-action-css-property.

13 enum TouchAction {	13 enum TouchAction {

	14 // All actions are pemitted (the default).

	15 TOUCH_ACTION_AUTO = 0,
	jdduke (slow) 2013/12/19 16:17:16 In the future, having TOUCH_ACTION_AUTO be the uni In the future, having TOUCH_ACTION_AUTO be the union of the flags, with TOUCH_ACTION_NONE == 0 might be useful, but there are few enough combinations here it's not a big deal. Rick Byers 2013/12/19 16:35:09 We can't actually - the semantics are different. Show quoted text On 2013/12/19 16:17:16, jdduke wrote: > > In the future, having TOUCH_ACTION_AUTO be the union of the flags, with > TOUCH_ACTION_NONE == 0 might be useful, but there are few enough combinations > here it's not a big deal. We can't actually - the semantics are different. Auto permits pinching for example where TOUCH_ACTION_PAN_X \| TOUCH_ACTION_PAN_Y doesn't. So there's always going to be some 'flag' that can't be combined with any others. We debated a little on the blink side (and changed it once) about whether AUTO or NONE should have the value 0 - the benefit to AUTO being 0 is that AUTO is the default (same as unspecified) and so will be the 99% common case on the web for awhile. But as long as we have this impure-flags semantics, then it's never going to be simple. Also I now COMPILE_ASSERT that the 3 different definitions of this enum match their values exactly. See http://msdn.microsoft.com/en-us/library/Windows/Apps/hh767313.aspx for details on the larger set of semantics IE has here.
	16

14 // No scrolling or zooming allowed.	17 // No scrolling or zooming allowed.

15 TOUCH_ACTION_NONE,	18 TOUCH_ACTION_NONE = 1 << 0,

16	19

17 // All actions are pemitted (the default).	20 TOUCH_ACTION_PAN_X = 1 << 1,

18 TOUCH_ACTION_AUTO,

19	21

20 TOUCH_ACTION_MAX = TOUCH_ACTION_AUTO	22 TOUCH_ACTION_PAN_Y = 1 << 2,

	23

	24 TOUCH_ACTION_PAN_X_Y = TOUCH_ACTION_PAN_X \| TOUCH_ACTION_PAN_Y,

	25

	26 TOUCH_ACTION_MAX = (1 << 3) - 1

21 };	27 };

22	28

23 } // namespace content	29 } // namespace content

24	30

25 #endif // CONTENT_COMMON_INPUT_TOUCH_ACTION_H_	31 #endif // CONTENT_COMMON_INPUT_TOUCH_ACTION_H_

OLD	NEW