Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 937313003: chrome: Remove the use of WebWorkerRunLoop. (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: Remove the use of WebWorkerRunLoop. WebWorkerRunLoop serves no purpose anymore. So remove its use from chrome. This is part 1 of 3. Part 2: https://codereview.chromium.org/960443002 Part 3: https://codereview.chromium.org/955883002 BUG=461664 Committed: https://crrev.com/721ec7f8578afb27b9664641b109d483439b9859 Cr-Commit-Position: refs/heads/master@{#318235}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M content/child/blink_platform_impl.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M content/child/worker_task_runner.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/worker_task_runner.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/worker_task_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sadrul
5 years, 10 months ago (2015-02-25 04:00:24 UTC) #2
kinuko
lgtm https://codereview.chromium.org/937313003/diff/20001/content/child/blink_platform_impl.cc File content/child/blink_platform_impl.cc (right): https://codereview.chromium.org/937313003/diff/20001/content/child/blink_platform_impl.cc#newcode1041 content/child/blink_platform_impl.cc:1041: void BlinkPlatformImpl::didStartWorkerRunLoop( nit: would be nice to have ...
5 years, 10 months ago (2015-02-26 03:28:03 UTC) #3
sadrul
https://codereview.chromium.org/937313003/diff/20001/content/child/blink_platform_impl.cc File content/child/blink_platform_impl.cc (right): https://codereview.chromium.org/937313003/diff/20001/content/child/blink_platform_impl.cc#newcode1041 content/child/blink_platform_impl.cc:1041: void BlinkPlatformImpl::didStartWorkerRunLoop( On 2015/02/26 03:28:03, kinuko wrote: > nit: ...
5 years, 10 months ago (2015-02-26 05:00:22 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-26 15:04:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937313003/40001
5 years, 10 months ago (2015-02-26 15:27:36 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 15:36:25 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 15:37:47 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/721ec7f8578afb27b9664641b109d483439b9859
Cr-Commit-Position: refs/heads/master@{#318235}

Powered by Google App Engine
This is Rietveld 408576698