Unify request failure handling in content::UserMediaClientImpl

Unify request failure handling in content::UserMediaClientImpl

Unify UserMediaClientImpl::GetUserMediaRequestFailed and
UserMediaClientImpl::GetUserMediaRequestTrackStartedFailed
and make sure all possible enum values are handled in the
switch.

BUG=459694
Committed: https://crrev.com/e4af29985a69116a4d37bf7c8130336c63542adc
Cr-Commit-Position: refs/heads/master@{#317464}

[servolk, 2015-02-19 22:46:46]

servolk@chromium.org changed reviewers:
+ grunell@chromium.org, mfoltz@chromium.org, miu@chromium.org,
perkj@chromium.org

[servolk, 2015-02-19 22:48:32]

How about this? We could unify the failed request handling in a single method.
I've also put the case values in the declaration order. Note: I still went with
"MediaDeviceNotSupported", to make this name less confusing when only one of the
devices is supported (e.g. microphone is present, but not a webcam).

[servolk, 2015-02-19 22:50:46]

servolk@chromium.org changed reviewers:
+ dalecurtis@chromium.org, scherkus@chromium.org

[perkj_chrome, 2015-02-20 11:26:04]

lgtm

[scherkus (not reviewing), 2015-02-20 17:48:11]

lgtm

[servolk, 2015-02-20 18:51:26]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937293002/1

[commit-bot: I haz the power, 2015-02-20 19:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:47:45]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[mark a. foltz, 2015-02-20 20:00:21]

https://codereview.chromium.org/937293002/diff/1/content/renderer/media/user_...
File content/renderer/media/user_media_client_impl.cc (right):

https://codereview.chromium.org/937293002/diff/1/content/renderer/media/user_...
content/renderer/media/user_media_client_impl.cc:759: break;
s/break/return/

https://codereview.chromium.org/937293002/diff/1/content/renderer/media/user_...
content/renderer/media/user_media_client_impl.cc:762: break;
Ditto

[miu, 2015-02-20 22:35:35]

lgtm, but please change "break" to "return" as mfoltz@ pointed out before
committing.

[servolk, 2015-02-20 23:15:02]

New patchsets have been uploaded after l-g-t-m from
perkj@chromium.org,scherkus@chromium.org,miu@chromium.org

[servolk, 2015-02-20 23:16:07]

On 2015/02/20 22:35:35, miu wrote:
> lgtm, but please change "break" to "return" as mfoltz@ pointed out before
> committing.

done + fixed build break in unit test code

[servolk, 2015-02-20 23:16:16]

https://codereview.chromium.org/937293002/diff/1/content/renderer/media/user_...
File content/renderer/media/user_media_client_impl.cc (right):

https://codereview.chromium.org/937293002/diff/1/content/renderer/media/user_...
content/renderer/media/user_media_client_impl.cc:759: break;
On 2015/02/20 20:00:21, mark a. foltz wrote:
> s/break/return/

Good catch. thanks!

[servolk, 2015-02-20 23:19:28]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2015-02-20 23:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937293002/20001

[commit-bot: I haz the power, 2015-02-21 00:53:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-21 00:54:22]

Patchset 2 (id:??) landed as
https://crrev.com/e4af29985a69116a4d37bf7c8130336c63542adc
Cr-Commit-Position: refs/heads/master@{#317464}