Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 937283002: Subzero makefile changes for linking a static llvm2ice nexe w/ LLVM build sys. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero makefile changes for linking a static llvm2ice nexe w/ LLVM build sys. Need to list more dependencies, otherwise the static link fails. The current unsandboxed build is a shared build which uses libLLVM-3.*.so. Also mess with the CXXFlags a bit. The current pnacl-llc nexe build uses O3, but that triggers a method pointer bug: https://code.google.com/p/nativeclient/issues/detail?id=3857, so override that with O2. We may just want to change the pnacl-llc build as well (maybe use Os), but I don't know of the performance implications right now. Use gnu++11, because of newlib + libc++. Toggle the feature flags to be a MINIMAL build when building the sandboxed translator w/ the LLVM-based Makefile. Goes with build script change https://codereview.chromium.org/945473003/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3857 R=dschuff@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e837e1a38b79ddf82f5497d80a4c2fe87241dff2

Patch Set 1 #

Patch Set 2 : revert #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M Makefile View 1 2 1 chunk +15 lines, -5 lines 0 comments Download
M Makefile.standalone View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/Makefile View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-19 23:11:34 UTC) #2
Karl
lgtm
5 years, 10 months ago (2015-02-19 23:15:34 UTC) #3
Derek Schuff
lgtm
5 years, 10 months ago (2015-02-23 17:06:21 UTC) #4
jvoung (off chromium)
5 years, 9 months ago (2015-03-02 22:22:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e837e1a38b79ddf82f5497d80a4c2fe87241dff2 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698