Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 937233002: add flag to stage mipmap change (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add flag to stage mipmap change prereq for https://codereview.chromium.org/916103008 BUG= Committed: https://crrev.com/da7f1e17a054f8e26f5445b6f6dba7bf109c3095 Cr-Commit-Position: refs/heads/master@{#317145}

Patch Set 1 #

Total comments: 2

Patch Set 2 : align indents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
reed1
ptal
5 years, 10 months ago (2015-02-19 21:14:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937233002/1
5 years, 10 months ago (2015-02-19 21:14:49 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-19 21:14:51 UTC) #6
f(malita)
lgtm https://codereview.chromium.org/937233002/diff/1/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/937233002/diff/1/skia/config/SkUserConfig.h#newcode256 skia/config/SkUserConfig.h:256: #ifndef SK_SUPPORT_LEGACY_MIPMAP_EFFECTIVE_SCALE Nit: indentation one-off?
5 years, 10 months ago (2015-02-19 21:15:30 UTC) #7
reed1
https://codereview.chromium.org/937233002/diff/1/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/937233002/diff/1/skia/config/SkUserConfig.h#newcode256 skia/config/SkUserConfig.h:256: #ifndef SK_SUPPORT_LEGACY_MIPMAP_EFFECTIVE_SCALE On 2015/02/19 21:15:29, f(malita) wrote: > Nit: ...
5 years, 10 months ago (2015-02-19 21:17:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937233002/20001
5 years, 10 months ago (2015-02-19 21:17:44 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 22:22:13 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 22:22:38 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/da7f1e17a054f8e26f5445b6f6dba7bf109c3095
Cr-Commit-Position: refs/heads/master@{#317145}

Powered by Google App Engine
This is Rietveld 408576698