Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 937153003: Document the idiosyncrasies of policy provisioning on Windows. (Closed)

Created:
5 years, 10 months ago by Thiemo Nagel
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document the idiosyncrasies of policy provisioning on Windows. BUG=457542 Committed: https://crrev.com/6cde0ff0270b389731bf28105c6d582e09fd9446 Cr-Commit-Position: refs/heads/master@{#317582}

Patch Set 1 #

Patch Set 2 : At that occasion: remove superflous namespace qualifiers. #

Total comments: 2

Patch Set 3 : Rebase. #

Patch Set 4 : Add missing comma. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M components/policy/core/common/policy_loader_win.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 3 8 chunks +31 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Thiemo Nagel
Hi Julian, could you please take a look whether the documentation that I've created following ...
5 years, 10 months ago (2015-02-19 16:41:16 UTC) #2
pastarmovj
lgtm
5 years, 10 months ago (2015-02-23 11:03:08 UTC) #3
Thiemo Nagel
Since we've been discussing the details of policy reading on Windows, could you please take ...
5 years, 10 months ago (2015-02-23 11:37:44 UTC) #5
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/937153003/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/937153003/diff/20001/components/policy/resources/policy_templates.json#newcode1809 components/policy/resources/policy_templates.json:1809: For Windows instances that are not joined to ...
5 years, 10 months ago (2015-02-23 12:15:47 UTC) #6
Thiemo Nagel
Thank you, Drew! https://codereview.chromium.org/937153003/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/937153003/diff/20001/components/policy/resources/policy_templates.json#newcode1809 components/policy/resources/policy_templates.json:1809: For Windows instances that are not ...
5 years, 10 months ago (2015-02-23 13:39:18 UTC) #8
Thiemo Nagel
And thank you, Julian!
5 years, 10 months ago (2015-02-23 13:39:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937153003/60001
5 years, 10 months ago (2015-02-23 13:40:47 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-23 14:25:21 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 14:25:53 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6cde0ff0270b389731bf28105c6d582e09fd9446
Cr-Commit-Position: refs/heads/master@{#317582}

Powered by Google App Engine
This is Rietveld 408576698