Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 937143002: Files.app: Keep file-type icon visible while renaming. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Keep file-type icon visible while renaming. BUG=459165 TEST=Trigger renaming on list and grid view, and check the icons. Committed: https://crrev.com/f857b9cf52a475af5587cf14b1bb255d7ca5a6a3 Cr-Commit-Position: refs/heads/master@{#317032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-19 12:03:38 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-19 12:20:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937143002/1
5 years, 10 months ago (2015-02-19 12:21:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 12:44:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 12:45:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f857b9cf52a475af5587cf14b1bb255d7ca5a6a3
Cr-Commit-Position: refs/heads/master@{#317032}

Powered by Google App Engine
This is Rietveld 408576698