Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 93713007: Update 4 skimage expectations. (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update 4 skimage expectations. Grab expectations missed in https://codereview.chromium.org/102213009/, since the bots were slow: - Test-ChromeOS-Daisy-MaliT604-Arm7-Debug - Test-ChromeOS-Daisy-MaliT604-Arm7-Release - Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind - Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN BUG= R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=12869

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -48 lines) Patch
M expectations/skimage/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 2 chunks +12 lines, -12 lines 0 comments Download
M expectations/skimage/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 2 chunks +12 lines, -12 lines 0 comments Download
M expectations/skimage/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/expected-results.json View 2 chunks +12 lines, -12 lines 0 comments Download
M expectations/skimage/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hal.canary
this is exactly what it looks like
6 years, 11 months ago (2014-01-02 19:01:01 UTC) #1
epoger
rubberstamp LGTM (we need a tool so reviewers can see the image diffs)
6 years, 11 months ago (2014-01-02 20:33:52 UTC) #2
hal.canary
6 years, 11 months ago (2014-01-02 20:43:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r12869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698