Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 937083002: Files.app: Re-design dialog footer. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Re-design dialog footer. BUG=402344 TEST=compared with the design spec manually. Committed: https://crrev.com/ebf709475087e02f634bd0a61f8b1607d55d153c Cr-Commit-Position: refs/heads/master@{#317030}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a TODO comment for command button. #

Patch Set 3 : Update tag name from button to paper-button in test code. #

Messages

Total messages: 13 (5 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-19 07:02:48 UTC) #2
hirono
lgtm! https://codereview.chromium.org/937083002/diff/1/ui/file_manager/file_manager/main.html File ui/file_manager/file_manager/main.html (right): https://codereview.chromium.org/937083002/diff/1/ui/file_manager/file_manager/main.html#newcode452 ui/file_manager/file_manager/main.html:452: <button id="new-folder-button" class="primary" Could you please add TODO ...
5 years, 10 months ago (2015-02-19 07:13:19 UTC) #3
fukino
Thank you! https://codereview.chromium.org/937083002/diff/1/ui/file_manager/file_manager/main.html File ui/file_manager/file_manager/main.html (right): https://codereview.chromium.org/937083002/diff/1/ui/file_manager/file_manager/main.html#newcode452 ui/file_manager/file_manager/main.html:452: <button id="new-folder-button" class="primary" On 2015/02/19 07:13:19, hirono ...
5 years, 10 months ago (2015-02-19 07:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937083002/20001
5 years, 10 months ago (2015-02-19 07:22:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/26916)
5 years, 10 months ago (2015-02-19 08:37:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937083002/40001
5 years, 10 months ago (2015-02-19 11:13:40 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 11:38:21 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 11:39:17 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ebf709475087e02f634bd0a61f8b1607d55d153c
Cr-Commit-Position: refs/heads/master@{#317030}

Powered by Google App Engine
This is Rietveld 408576698