Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 937073003: Enabled gpu_times metrics. (Closed)

Created:
5 years, 10 months ago by David Yen
Modified:
5 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled gpu_times metrics. The issue where gpu_times would use too much memory has been fixed: https://codereview.chromium.org/920523002 In order to prepare for future changes where additional metrics will be added to the TBM module, I have also preemptively added a filter function which filters out values relating to gpu_times. R=nednguyen@chromium.org BUG=455292, 453131 TEST=local runs measuring memory usage shows ~700mb Committed: https://crrev.com/ed5b27a7459e35248992fd5549b72b5731a8baa4 Cr-Commit-Position: refs/heads/master@{#317974}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M tools/perf/benchmarks/gpu_times.py View 4 chunks +8 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 2 chunks +23 lines, -12 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
David Yen
5 years, 10 months ago (2015-02-24 23:16:15 UTC) #1
David Yen
On 2015/02/24 23:16:15, David Yen wrote: +nednguyen
5 years, 10 months ago (2015-02-24 23:16:48 UTC) #3
nednguyen
https://codereview.chromium.org/937073003/diff/1/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py File tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py (right): https://codereview.chromium.org/937073003/diff/1/tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py#newcode32 tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py:32: super(GPUTimelineValue, self).__init__(page, name, 'ms', value) +1 I like this.
5 years, 10 months ago (2015-02-25 02:55:25 UTC) #4
nednguyen
lgtm
5 years, 10 months ago (2015-02-25 02:55:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937073003/1
5 years, 10 months ago (2015-02-25 03:09:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 04:58:10 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed5b27a7459e35248992fd5549b72b5731a8baa4 Cr-Commit-Position: refs/heads/master@{#317974}
5 years, 10 months ago (2015-02-25 04:58:59 UTC) #9
nednguyen
5 years, 10 months ago (2015-02-25 13:22:55 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/952133003/ by nednguyen@google.com.

The reason for reverting is: Causing not redness..

Powered by Google App Engine
This is Rietveld 408576698