Issue 93703005: The register keyword is deprecated in C++, even at -O0, registers are used automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93703005: The register keyword is deprecated in C++, even at -O0, registers are used automatically. (Closed)

Created:
7 years ago by djsollen

Modified:
7 years ago

Reviewers:
scroggo, mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

The register keyword is deprecated in C++, even at -O0, registers are used automatically. Having the register keyword there causes a warning about deprecated keywords when using clang (and possibly future gcc versions), and isn't needed. Patch originally submitted to AOSP https://android-review.googlesource.com/#/c/72501 Committed: http://code.google.com/p/skia/source/detail?r=12702

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	include/core/SkFixed.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/93703005/1

7 years ago (2013-12-16 23:19:29 UTC) #4

kevin.petit.not.used.account

7 years ago (2013-12-17 15:00:24 UTC) #6

Message was sent while issue was closed.

register is used in many places in NEON code, maybe you want to remove them...