Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 937023002: Merge hitTestLayerByApplyingTransform into hitTestLayer. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge hitTestLayerByApplyingTransform into hitTestLayer. This makes hitTestLayer a bit larger at the benefit of making the code a bit easier to follow and getting rid of the confusing recursive call to hitTestLayer and the appliedTransform bool. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/99c3bbe704888463d233c0eca973db8a051cb6cf

Patch Set 1 #

Patch Set 2 : only call createLocalTransformState once #

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -55 lines) Patch
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 2 7 chunks +38 lines, -51 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-19 02:21:53 UTC) #2
ojan
5 years, 10 months ago (2015-02-19 02:40:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
99c3bbe704888463d233c0eca973db8a051cb6cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698