Enhance GN introspection

tools/gn/command_check.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "tools/gn/commands.h"
 #include "tools/gn/header_checker.h"
 #include "tools/gn/setup.h"
 #include "tools/gn/standard_out.h"
@@ skipping 52 matching lines @@
   if (!setup->DoSetup(args[0], false))
     return 1;
   if (!setup->Run())
     return 1;
 
   std::vector<const Target*> all_targets =
       setup->builder()->GetAllResolvedTargets();
 
   bool filtered_by_build_config = false;
   std::vector<const Target*> targets_to_check;
-  if (args.size() == 2) {
-    // Compute the target to check.
-    if (!ResolveTargetsFromCommandLinePattern(setup, args[1], false,
-                                              &targets_to_check))
+  if (args.size() > 1) {
+    // Compute the targets to check.
+    std::vector<std::string> inputs(args.begin() + 1, args.end());
+    UniqueVector<const Target*> target_matches;
+    UniqueVector<const Config*> config_matches;
+    UniqueVector<const Toolchain*> toolchain_matches;
+    UniqueVector<SourceFile> file_matches;
+    if (!ResolveFromCommandLineInput(setup, inputs, false,
+                                     &target_matches, &config_matches,
+                                     &toolchain_matches, &file_matches))
       return 1;
-    if (targets_to_check.size() == 0) {
+
+    if (target_matches.size() == 0) {
       OutputString("No matching targets.\n");
       return 1;
     }
+    targets_to_check.insert(targets_to_check.begin(),
+                            target_matches.begin(), target_matches.end());
   } else {
     // No argument means to check everything allowed by the filter in
     // the build config file.
     if (setup->check_patterns()) {
       FilterTargetsByPatterns(all_targets, *setup->check_patterns(),
                               &targets_to_check);
       filtered_by_build_config = targets_to_check.size() != all_targets.size();
     } else {
       // No global filter, check everything.
       targets_to_check = all_targets;
@@ skipping 33 matching lines @@
   std::vector<Err> header_errors;
   header_checker->Run(to_check, force_check, &header_errors);
   for (size_t i = 0; i < header_errors.size(); i++) {
     if (i > 0)
       OutputString("___________________\n", DECORATION_YELLOW);
     header_errors[i].PrintToStdout();
   }
   return header_errors.empty();
 }
 
-void FilterTargetsByPatterns(const std::vector<const Target*>& input,
-                             const std::vector<LabelPattern>& filter,
-                             std::vector<const Target*>* output) {
-  for (const auto& target : input) {
-    for (const auto& pattern : filter) {
-      if (pattern.Matches(target->label())) {
-        output->push_back(target);
-        break;
-      }
-    }
-  }
-}
-
 }  // namespace commands