Enhance GN introspection

Enhance GN introspection

This adds additional matching and output capabilities to the various GN introspection commands (desc, ls, refs). It adds --as for controlling output, and --testonly and --type for controlling which ones to show.

It adds support for matching multiple input arguments for the refs, ls, and check commands.

It adds support for finding which targets reference a config in the refs command.

Committed: https://crrev.com/e604e508f8b3b08d89b5e98ef1d376c74d471a38
Cr-Commit-Position: refs/heads/master@{#317159}

[brettw, 2015-02-19 21:28:10]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-02-19 21:52:02]

lgtm

https://codereview.chromium.org/937003002/diff/60001/tools/gn/command_ls.cc
File tools/gn/command_ls.cc (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/command_ls.cc#n...
tools/gn/command_ls.cc:21: "gn ls <out_dir> [<label_pattern>] [--out]
[--all-toolchains]\n"
--as, --type, etc?

https://codereview.chromium.org/937003002/diff/60001/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/command_refs.cc...
tools/gn/command_refs.cc:252: "gn refs <out_dir>
(<label_pattern>|<label>|<file>)* [--files] [--tree]\n"
--as, etc?

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.cc
File tools/gn/commands.cc (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.cc#new...
tools/gn/commands.cc:25: // If all_tolchains is false, a pattern with an
unspecified toolchain will
all_toolchains

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.cc#new...
tools/gn/commands.cc:429: void FilterTargetsByPatterns(const std::vector<const
Target*>& input,
this could be template <class O> for output

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.h
File tools/gn/commands.h (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.h#newc...
tools/gn/commands.h:159: "  --testonly=(true|false)\n"\
seems a bit weird to have this be a true|false when then default is false, just
--testonly as an option maybe?

[brettw, 2015-02-19 22:12:02]

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.cc
File tools/gn/commands.cc (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.cc#new...
tools/gn/commands.cc:429: void FilterTargetsByPatterns(const std::vector<const
Target*>& input,
On 2015/02/19 21:52:01, scottmg wrote:
> this could be template <class O> for output

Yeah, but I didn't feel like I should implement this in the header.

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.h
File tools/gn/commands.h (right):

https://codereview.chromium.org/937003002/diff/60001/tools/gn/commands.h#newc...
tools/gn/commands.h:159: "  --testonly=(true|false)\n"\
On 2015/02/19 21:52:01, scottmg wrote:
> seems a bit weird to have this be a true|false when then default is false,
just
> --testonly as an option maybe?

The default isn't false, the default is "don't check". Saying testonly=false
returns only non-test targets.

[brettw, 2015-02-19 22:12:19]

New patchsets have been uploaded after l-g-t-m from scottmg@chromium.org

[brettw, 2015-02-19 22:12:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-19 22:13:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937003002/80001

[commit-bot: I haz the power, 2015-02-19 23:03:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-19 23:03:36]

Patchset 5 (id:??) landed as
https://crrev.com/e604e508f8b3b08d89b5e98ef1d376c74d471a38
Cr-Commit-Position: refs/heads/master@{#317159}