Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: skia/BUILD.gn

Issue 936953004: Add more targets to GN check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move net function Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/websockets/websocket_test_util.h ('k') | skia/ext/analysis_canvas.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/BUILD.gn
diff --git a/skia/BUILD.gn b/skia/BUILD.gn
index c793e0b9e5c010d1c7ccc4438a8fef473ac4401b..b134de98f4b81a575fb9badcf8c174f885d80601 100644
--- a/skia/BUILD.gn
+++ b/skia/BUILD.gn
@@ -311,6 +311,9 @@ component("skia") {
sources += gypi_skia_utils.sources
sources += gypi_values.skia_library_sources
+ # This and skia_opts are really the same conceptual target so share headers.
+ allow_circular_includes_from = [ ":skia_opts" ]
+
if (cpu_arch == "arm") {
sources += [
"//third_party/skia/src/core/SkUtilsArm.cpp",
@@ -624,6 +627,7 @@ test("skia_unittests") {
":skia",
"//base",
"//base/test:run_all_unittests",
+ "//cc:test_support",
Dirk Pranke 2015/02/20 00:40:12 This seems a bit odd; skia depends on cc ?
brettw 2015/02/20 00:53:43 Yes, the pixel_ref_utils_unittest uses some helper
"//testing/gtest",
"//ui/gfx",
"//ui/gfx/geometry",
« no previous file with comments | « net/websockets/websocket_test_util.h ('k') | skia/ext/analysis_canvas.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698