Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: .gn

Issue 936953004: Add more targets to GN check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move net function Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/BUILD.gn » ('j') | skia/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
11 secondary_source = "//build/secondary/" 11 secondary_source = "//build/secondary/"
12 12
13 # These are the targets to check headers for by default. The files in targets 13 # These are the targets to check headers for by default. The files in targets
14 # matching these patterns (see "gn help label_pattern" for format) will have 14 # matching these patterns (see "gn help label_pattern" for format) will have
15 # their includes checked for proper dependencies when you run either 15 # their includes checked for proper dependencies when you run either
16 # "gn check" or "gn gen --check". 16 # "gn check" or "gn gen --check".
17 check_targets = [ 17 check_targets = [
18 #"//apps/*", # Medium-hard.
19 #"//ash/*", # Medium-hard.
18 # Requires GN binary >= 314794 and to mark the "...__generate_enum" action in 20 # Requires GN binary >= 314794 and to mark the "...__generate_enum" action in
19 # build/config/android/rules.gni "java_cpp_enum" template with 21 # build/config/android/rules.gni "java_cpp_enum" template with
20 # check_includes = false. 22 # check_includes = false.
21 #"//base/*", 23 #"//base/*",
24 "//blink/*",
25 "//breakpad/*",
22 "//build/*", 26 "//build/*",
23 "//cc/*", 27 "//cc/*",
28
29 #"//chrome/*", # Epic number of errors.
30 "//chromecast/*",
31 "//chrome_elf/*",
32 "//cloud_print/*",
33
34 #"//components/*", # Lots of errors.
35 #"//content/*", # A whole lot of errors.
36 "//courgette/*",
37 "//crypto/*",
38 "//data/*",
24 "//dbus/*", 39 "//dbus/*",
25 "//device/*", 40 "//device/*",
41
42 #"//extensions/*", # Lots of errors.
43 #"//gin/*", # Easy.
44 #"//google_apis/*", # Easy.
45 "//google_update/*",
46
47 #"//gpu/*", # Lots of errors.
48 #"//ios/*",
26 "//ipc/*", 49 "//ipc/*",
50
51 #"//jingle/*",
52 #"//media/*", # Lots of errors.
53 #"//mojo/*",
54 #"//native_client/*",
55 "//net/*",
56
57 #"//pdf/*", # Medium-hard.
58 #"//ppapi/*", # Lots of errors.
59 "//printing/*",
60
61 #"//remoting/*", # Medium-hard.
62 #"//rlz/*", # Needs checking on Windows.
63 #"//sandbox/*", # Medium-hard.
64 "//sdch/*",
65 "//skia/*",
27 "//sql/*", 66 "//sql/*",
28 "//storage/*", 67 "//storage/*",
68 "//sync/*",
69 "//testing/*",
70
71 #"//third_party/*", # May not ever want this.
72 "//tools/*",
73
74 #"//ui/*", # Just a few problems.
29 "//url/*", 75 "//url/*",
76 "//v8/*",
30 ] 77 ]
OLDNEW
« no previous file with comments | « no previous file | net/BUILD.gn » ('j') | skia/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698