Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 936793003: Align GetIterator with ES6 spec (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Align GetIterator with ES6 spec BUG=None LOG=N R=adamk Committed: https://crrev.com/b9f006a4047c0c486302adb6850900e6e8a1a0db Cr-Commit-Position: refs/heads/master@{#26759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 1 chunk +3 lines, -13 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/collections.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-19 21:00:56 UTC) #1
adamk
lgtm
5 years, 10 months ago (2015-02-19 21:15:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936793003/1
5 years, 10 months ago (2015-02-19 21:16:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 21:38:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9f006a4047c0c486302adb6850900e6e8a1a0db Cr-Commit-Position: refs/heads/master@{#26759}
5 years, 10 months ago (2015-02-19 21:38:31 UTC) #6
arv (Not doing code reviews)
5 years, 10 months ago (2015-02-20 16:19:11 UTC) #7
Message was sent while issue was closed. 
This kept me up all night... this is not quite right either. I had to do some
deep spec diving to figure out what we should do here and I ended up filing a
bug on Spidermonkey...

A new patch is coming.

Powered by Google App Engine
This is Rietveld 408576698