Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 93673005: Revert of ensure that we call onUnlock only when we onLock succeeded (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M include/core/SkPixelRef.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/core/SkPixelRef.cpp View 2 chunks +3 lines, -12 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M src/images/SkImageRef_ashmem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
Created Revert of ensure that we call onUnlock only when we onLock succeeded
7 years ago (2013-12-12 18:06:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/93673005/1
7 years ago (2013-12-12 18:06:41 UTC) #2
commit-bot: I haz the power
Presubmit check for 93673005-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years ago (2013-12-12 18:06:45 UTC) #3
reed1
lgtm
7 years ago (2013-12-12 18:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/93673005/1
7 years ago (2013-12-12 18:08:01 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-12 18:08:11 UTC) #6
Message was sent while issue was closed.
Change committed as 12646

Powered by Google App Engine
This is Rietveld 408576698