Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 936653004: Disable unprefixed EME when using "--mediadrm-enable-non-compositing". (Closed)

Created:
5 years, 10 months ago by ddorwin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@_andorid-wv
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable unprefixed EME when using "--mediadrm-enable-non-compositing". This is temporary until we can determine a permanent solution. This cannot be implemented at a lower level because the lower levels do not know which version of EME is being used. BUG=394926 Committed: https://crrev.com/d5b91fc669d94d02b4293b46bbea83120b99fc08 Cr-Commit-Position: refs/heads/master@{#316944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
ddorwin
5 years, 10 months ago (2015-02-18 01:30:15 UTC) #2
ddorwin
lcwu & benm: PTAL. See the bug for background.
5 years, 10 months ago (2015-02-18 01:39:11 UTC) #4
ycheo (away)
LGTM. unprefixed EME was enabled at Jan/26/2015, so this may not affect the behavior of ...
5 years, 10 months ago (2015-02-18 03:06:23 UTC) #6
ddorwin
On 2015/02/18 03:06:23, ycheo (away) wrote: > LGTM. > unprefixed EME was enabled at Jan/26/2015, ...
5 years, 10 months ago (2015-02-18 04:40:47 UTC) #7
lcwu1
chromecast lgtm
5 years, 10 months ago (2015-02-19 00:31:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936653004/1
5 years, 10 months ago (2015-02-19 00:39:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43705)
5 years, 10 months ago (2015-02-19 00:45:39 UTC) #12
ddorwin
boliu or benm: Please OWNERS review the small change in android_webview/lib/main/aw_main_delegate.cc.
5 years, 10 months ago (2015-02-19 00:48:58 UTC) #14
boliu
rs lgtm
5 years, 10 months ago (2015-02-19 00:58:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936653004/1
5 years, 10 months ago (2015-02-19 01:02:14 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 01:06:59 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:07:57 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5b91fc669d94d02b4293b46bbea83120b99fc08
Cr-Commit-Position: refs/heads/master@{#316944}

Powered by Google App Engine
This is Rietveld 408576698