Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 936633003: Move Node.baseURI to JS prototype chains (Closed)

Created:
5 years, 10 months ago by haraken
Modified:
5 years, 10 months ago
Reviewers:
Yuki
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Node.baseURI to JS prototype chains Node.baseURI is used by a micro-benchmark (PerformanceTests/Bindings/dom-attributes-on-prototype.html), which evaluates performance of DOM attributes on prototype chains. This benchmark is used by the V8 team for their optimization work, so it is important to have Node.baseURI on a prototype chain. This CL will slightly regress PerformanceTests/Bindings/dom-attributes-on-prototype.html, but it won't be an issue since real-world sites shouldn't be using baseURI heavily. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190421

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
haraken
PTAL
5 years, 10 months ago (2015-02-18 04:28:14 UTC) #2
Yuki
lgtm
5 years, 10 months ago (2015-02-18 04:30:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936633003/1
5 years, 10 months ago (2015-02-18 04:31:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/47473)
5 years, 10 months ago (2015-02-18 06:26:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936633003/20001
5 years, 10 months ago (2015-02-18 07:45:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/35544) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 10 months ago (2015-02-18 07:47:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936633003/60001
5 years, 10 months ago (2015-02-18 08:06:24 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/43420)
5 years, 10 months ago (2015-02-18 10:20:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/936633003/60001
5 years, 10 months ago (2015-02-18 12:30:37 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 13:25:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190421

Powered by Google App Engine
This is Rietveld 408576698