ui/compositor/layer.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/compositor/layer.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/compositor/layer.h

diff --git a/ui/compositor/layer.h b/ui/compositor/layer.h

index ff2f7da4f84cc96890a584f757c732e16f25dc17..f52c40fef37d4883efc5843b2a97343a7e96e77b 100644

--- a/ui/compositor/layer.h

+++ b/ui/compositor/layer.h

@@ -316,7 +316,7 @@ class COMPOSITOR_EXPORT Layer

// ContentLayerClient

virtual void PaintContents(

- SkCanvas* canvas, gfx::Rect clip, gfx::RectF* opaque) OVERRIDE;

+ SkCanvas* canvas, const gfx::Rect& clip, gfx::RectF* opaque) OVERRIDE;

virtual void DidChangeLayerCanUseLCDText() OVERRIDE {}

cc::Layer* cc_layer() { return cc_layer_; }

« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | ui/compositor/layer.cc » ('j') | no next file with comments »