gpu/command_buffer/client/gles2_implementation.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/gles2_implementation.h

diff --git a/gpu/command_buffer/client/gles2_implementation.h b/gpu/command_buffer/client/gles2_implementation.h

index 102bd66abc10a34e5d12223262fc56e59df6b4f0..8a7ab68466d0f50bb11e6c5b86484f230f5e32d9 100644

--- a/gpu/command_buffer/client/gles2_implementation.h

+++ b/gpu/command_buffer/client/gles2_implementation.h

@@ -217,7 +217,7 @@ class GLES2_IMPL_EXPORT GLES2Implementation

// ContextSupport implementation.

virtual void Swap() OVERRIDE;

- virtual void PartialSwapBuffers(gfx::Rect sub_buffer) OVERRIDE;

+ virtual void PartialSwapBuffers(const gfx::Rect& sub_buffer) OVERRIDE;

virtual void SetSwapBuffersCompleteCallback(

const base::Closure& swap_buffers_complete_callback)

OVERRIDE;

« no previous file with comments | « gpu/command_buffer/client/context_support.h ('k') | gpu/command_buffer/client/gles2_implementation.cc » ('j') | no next file with comments »