content/renderer/gpu/compositor_software_output_device.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/compositor_software_output_device.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/gpu/compositor_software_output_device.cc

diff --git a/content/renderer/gpu/compositor_software_output_device.cc b/content/renderer/gpu/compositor_software_output_device.cc

index c37b958ad9e3f75c357726dc34e0e94bf6bd2d1c..e400060660ff3a1623de759ba265c92c3e767bc7 100644

--- a/content/renderer/gpu/compositor_software_output_device.cc

+++ b/content/renderer/gpu/compositor_software_output_device.cc

@@ -131,7 +131,8 @@ void CompositorSoftwareOutputDevice::DiscardBackbuffer() {

void CompositorSoftwareOutputDevice::EnsureBackbuffer() {

}

-SkCanvas* CompositorSoftwareOutputDevice::BeginPaint(gfx::Rect damage_rect) {

+SkCanvas* CompositorSoftwareOutputDevice::BeginPaint(

+ const gfx::Rect& damage_rect) {

DCHECK(CalledOnValidThread());

Buffer* previous = NULL;

« no previous file with comments | « content/renderer/gpu/compositor_software_output_device.h ('k') | gpu/command_buffer/client/context_support.h » ('j') | no next file with comments »