cc/trees/proxy.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/proxy.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/proxy.h

diff --git a/cc/trees/proxy.h b/cc/trees/proxy.h

index 8949a02c5a8824402007ff6df9157675f723a7c2..e9876902dec08b59528391f822bbb28d983e5af0 100644

--- a/cc/trees/proxy.h

+++ b/cc/trees/proxy.h

@@ -46,7 +46,7 @@ class CC_EXPORT Proxy {

virtual ~Proxy();

- virtual bool CompositeAndReadback(void* pixels, gfx::Rect rect) = 0;

+ virtual bool CompositeAndReadback(void* pixels, const gfx::Rect& rect) = 0;

virtual void FinishAllRendering() = 0;

@@ -68,7 +68,7 @@ class CC_EXPORT Proxy {

virtual void SetNeedsAnimate() = 0;

virtual void SetNeedsUpdateLayers() = 0;

virtual void SetNeedsCommit() = 0;

- virtual void SetNeedsRedraw(gfx::Rect damage_rect) = 0;

+ virtual void SetNeedsRedraw(const gfx::Rect& damage_rect) = 0;

virtual void SetNextCommitWaitsForActivation() = 0;

virtual void NotifyInputThrottledUntilCommit() = 0;

« no previous file with comments | « cc/trees/occlusion_tracker_unittest.cc ('k') | cc/trees/quad_culler.cc » ('j') | no next file with comments »