Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2603)

Unified Diff: cc/test/tiled_layer_test_common.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/tiled_layer_test_common.h ('k') | cc/trees/damage_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/tiled_layer_test_common.cc
diff --git a/cc/test/tiled_layer_test_common.cc b/cc/test/tiled_layer_test_common.cc
index 4db79e864e52fd1f6a9bc6674624537f424abd50..6dddfd33888dedf1baf6fe461529449bddd9487c 100644
--- a/cc/test/tiled_layer_test_common.cc
+++ b/cc/test/tiled_layer_test_common.cc
@@ -16,7 +16,7 @@ FakeLayerUpdater::Resource::Resource(FakeLayerUpdater* layer,
FakeLayerUpdater::Resource::~Resource() {}
void FakeLayerUpdater::Resource::Update(ResourceUpdateQueue* queue,
- gfx::Rect source_rect,
+ const gfx::Rect& source_rect,
gfx::Vector2d dest_offset,
bool partial_update) {
const gfx::Rect kRect(0, 0, 10, 10);
@@ -34,7 +34,7 @@ FakeLayerUpdater::FakeLayerUpdater() : prepare_count_(0), update_count_(0) {}
FakeLayerUpdater::~FakeLayerUpdater() {}
-void FakeLayerUpdater::PrepareToUpdate(gfx::Rect content_rect,
+void FakeLayerUpdater::PrepareToUpdate(const gfx::Rect& content_rect,
gfx::Size tile_size,
float contents_width_scale,
float contents_height_scale,
@@ -49,7 +49,7 @@ void FakeLayerUpdater::PrepareToUpdate(gfx::Rect content_rect,
*resulting_opaque_rect = opaque_paint_rect_;
}
-void FakeLayerUpdater::SetRectToInvalidate(gfx::Rect rect,
+void FakeLayerUpdater::SetRectToInvalidate(const gfx::Rect& rect,
FakeTiledLayer* layer) {
rect_to_invalidate_ = rect;
layer_ = layer;
« no previous file with comments | « cc/test/tiled_layer_test_common.h ('k') | cc/trees/damage_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698