cc/test/pixel_test.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/pixel_test.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/pixel_test.cc

diff --git a/cc/test/pixel_test.cc b/cc/test/pixel_test.cc

index 713f09ef26d7c9fcede553c36dc763f0d7a8b900..79824c0d68c5f2ae1d8003391bd624e3ee8df9f5 100644

--- a/cc/test/pixel_test.cc

+++ b/cc/test/pixel_test.cc

@@ -151,7 +151,7 @@ void PixelTest::ForceViewportOffset(gfx::Vector2d viewport_offset) {

external_device_viewport_offset_ = viewport_offset;

}

-void PixelTest::ForceDeviceClip(gfx::Rect clip) {

+void PixelTest::ForceDeviceClip(const gfx::Rect& clip) {

external_device_clip_rect_ = clip;

}

« no previous file with comments | « cc/test/pixel_test.h ('k') | cc/test/render_pass_test_utils.h » ('j') | no next file with comments »