cc/test/occlusion_tracker_test_common.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/occlusion_tracker_test_common.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/occlusion_tracker_test_common.h

diff --git a/cc/test/occlusion_tracker_test_common.h b/cc/test/occlusion_tracker_test_common.h

index af8ed3c470a1edcadab70f6685e23d70f94632a0..5468b99728f225bd22ef4b051a8b08e04e65725a 100644

--- a/cc/test/occlusion_tracker_test_common.h

+++ b/cc/test/occlusion_tracker_test_common.h

@@ -16,7 +16,7 @@ template <typename LayerType, typename RenderSurfaceType>

class TestOcclusionTrackerBase

: public OcclusionTrackerBase<LayerType, RenderSurfaceType> {

public:

- TestOcclusionTrackerBase(gfx::Rect screen_scissor_rect,

+ TestOcclusionTrackerBase(const gfx::Rect& screen_scissor_rect,

bool record_metrics_for_frame)

: OcclusionTrackerBase<LayerType, RenderSurfaceType>(

screen_scissor_rect,

« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/test/pixel_test.h » ('j') | no next file with comments »