cc/test/fake_proxy.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/fake_proxy.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/fake_proxy.h

diff --git a/cc/test/fake_proxy.h b/cc/test/fake_proxy.h

index 295cd9d0b3fc58ebeab0594b50bb406d3cb904bc..cda4e72ec19b487c584c767f60e80273a6dc1bba 100644

--- a/cc/test/fake_proxy.h

+++ b/cc/test/fake_proxy.h

@@ -21,7 +21,8 @@ class FakeProxy : public Proxy {

void SetLayerTreeHost(LayerTreeHost* host);

- virtual bool CompositeAndReadback(void* pixels, gfx::Rect rect) OVERRIDE;

+ virtual bool CompositeAndReadback(void* pixels,

+ const gfx::Rect& rect) OVERRIDE;

virtual void FinishAllRendering() OVERRIDE {}

virtual bool IsStarted() const OVERRIDE;

virtual void SetLayerTreeHostClientReady() OVERRIDE {}

@@ -31,7 +32,7 @@ class FakeProxy : public Proxy {

virtual void SetNeedsAnimate() OVERRIDE {}

virtual void SetNeedsUpdateLayers() OVERRIDE {}

virtual void SetNeedsCommit() OVERRIDE {}

- virtual void SetNeedsRedraw(gfx::Rect damage_rect) OVERRIDE {}

+ virtual void SetNeedsRedraw(const gfx::Rect& damage_rect) OVERRIDE {}

virtual void SetNextCommitWaitsForActivation() OVERRIDE {}

virtual void NotifyInputThrottledUntilCommit() OVERRIDE {}

virtual void SetDeferCommits(bool defer_commits) OVERRIDE {}

« no previous file with comments | « cc/test/fake_picture_layer_tiling_client.cc ('k') | cc/test/fake_proxy.cc » ('j') | no next file with comments »