cc/test/fake_picture_layer_tiling_client.h - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/fake_picture_layer_tiling_client.h

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/fake_picture_layer_tiling_client.h

diff --git a/cc/test/fake_picture_layer_tiling_client.h b/cc/test/fake_picture_layer_tiling_client.h

index 4b092e810f57b6ac46ed39eeaf390ed67a64d809..2e4e9d6019d57db2a656f15385f3bf8fd854b160 100644

--- a/cc/test/fake_picture_layer_tiling_client.h

+++ b/cc/test/fake_picture_layer_tiling_client.h

@@ -22,7 +22,7 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient {

// PictureLayerTilingClient implementation.

virtual scoped_refptr<Tile> CreateTile(

- PictureLayerTiling* tiling, gfx::Rect rect) OVERRIDE;

+ PictureLayerTiling* tiling, const gfx::Rect& rect) OVERRIDE;

virtual void UpdatePile(Tile* tile) OVERRIDE {}

virtual gfx::Size CalculateTileSize(

gfx::Size content_bounds) const OVERRIDE;

@@ -37,7 +37,7 @@ class FakePictureLayerTilingClient : public PictureLayerTilingClient {

const PictureLayerTiling* tiling) const OVERRIDE;

void set_twin_tiling(PictureLayerTiling* tiling) { twin_tiling_ = tiling; }

- void set_text_rect(gfx::Rect rect) { text_rect_ = rect; }

+ void set_text_rect(const gfx::Rect& rect) { text_rect_ = rect; }

void set_allow_create_tile(bool allow) { allow_create_tile_ = allow; }

void set_invalidation(const Region& region) { invalidation_ = region; }

« no previous file with comments | « cc/test/fake_output_surface_client.h ('k') | cc/test/fake_picture_layer_tiling_client.cc » ('j') | no next file with comments »