cc/resources/resource_provider.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/resource_provider.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/resource_provider.cc

diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc

index 3973fb8868c24a9a8d86b4eeea72e5f525dcec60..464d0a9dc9c4fa01c87ffa020e7d9f3d71a7825b 100644

--- a/cc/resources/resource_provider.cc

+++ b/cc/resources/resource_provider.cc

@@ -584,8 +584,8 @@ ResourceProvider::ResourceType ResourceProvider::GetResourceType(

void ResourceProvider::SetPixels(ResourceId id,

const uint8_t* image,

- gfx::Rect image_rect,

- gfx::Rect source_rect,

+ const gfx::Rect& image_rect,

+ const gfx::Rect& source_rect,

gfx::Vector2d dest_offset) {

Resource* resource = GetResource(id);

DCHECK(!resource->locked_for_write);

« no previous file with comments | « cc/resources/resource_provider.h ('k') | cc/resources/resource_update.h » ('j') | no next file with comments »