cc/resources/picture_layer_tiling_set.cc - Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/picture_layer_tiling_set.cc

Issue 93663004: [#2] Pass gfx structs by const ref (gfx::Rect, gfx::RectF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT, fix builds on non-linux platforms! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/picture_layer_tiling_set.cc

diff --git a/cc/resources/picture_layer_tiling_set.cc b/cc/resources/picture_layer_tiling_set.cc

index 5ad26506fd768c7b83f7c5324dfd8abf4e13adef..2047c3a7fed9f771453dafb02a5a2985c8ebe061 100644

--- a/cc/resources/picture_layer_tiling_set.cc

+++ b/cc/resources/picture_layer_tiling_set.cc

@@ -147,7 +147,7 @@ void PictureLayerTilingSet::RemoveAllTiles() {

PictureLayerTilingSet::CoverageIterator::CoverageIterator(

const PictureLayerTilingSet* set,

float contents_scale,

- gfx::Rect content_rect,

+ const gfx::Rect& content_rect,

float ideal_contents_scale)

: set_(set),

contents_scale_(contents_scale),

@@ -304,8 +304,8 @@ PictureLayerTilingSet::CoverageIterator::operator bool() const {

void PictureLayerTilingSet::UpdateTilePriorities(

WhichTree tree,

gfx::Size device_viewport,

- gfx::Rect viewport_in_content_space,

- gfx::Rect visible_content_rect,

+ const gfx::Rect& viewport_in_content_space,

+ const gfx::Rect& visible_content_rect,

gfx::Size last_layer_bounds,

gfx::Size current_layer_bounds,

float last_layer_contents_scale,

« no previous file with comments | « cc/resources/picture_layer_tiling_set.h ('k') | cc/resources/picture_layer_tiling_unittest.cc » ('j') | no next file with comments »